tree 124f54e9c0b406ad13c48ee8f854609d13e93c7a
parent 2a439e13bc37311fa24ca79132900f28902a3e3f
author Liu Hao <lh_mouse@126.com> 1556258940 +0800
committer Liu Hao <lh_mouse@126.com> 1557076254 +0800

winpthreads/cond.c: Remove waits for `sema_b` from wait functions.

All other functions wait for `sema_b` with `waiters_count_lock_` locked.
The order of acquisition of these two things must happen in the same order
in all functions, otherwise deadlocks may happen.

The obvious fix is to make wait functions wait for the semaphore after
having locked `waiters_count_lock_`. However, before the wait, the critical
seciton must be unlocked, otherwise all the other threads will be blocked
on signal/broadcast functions. The now consequent wait and signal operations
on the semaphore have no other effect and can be removed.

From now on, waiting threads will update `waiters_count_` without attempting
to lock `sema_b`. If a wait function is called under the protection of the
external mutex, this was unnecessary; otherwise, scheduling behavior might be
unpredictable, which nevertheless still conforms to POSIX.

Signed-off-by: Liu Hao <lh_mouse@126.com>